Skip to content

ITEP-33590 Dataset ie support for keypoint detection #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 30, 2025

Conversation

A-Artemis
Copy link
Contributor

@A-Artemis A-Artemis commented May 8, 2025

📝 Description

Added Dataset import/export support for Keypoint detection.
The Datumaro parsers are updated to the handle the edges and positions of the Keypoints.

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Run automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and descriptive
  • 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

@github-actions github-actions bot added the IAI Interactive AI backend label May 8, 2025
@A-Artemis A-Artemis changed the title Dataset ie support for keypoint detection ITEP-33590 Dataset ie support for keypoint detection May 8, 2025
@A-Artemis A-Artemis marked this pull request as ready for review May 9, 2025 06:43
@A-Artemis A-Artemis requested a review from a team as a code owner May 9, 2025 06:43
leoll2
leoll2 previously approved these changes May 12, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 20, 2025
@A-Artemis A-Artemis added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit fda7a6c May 30, 2025
22 checks passed
@A-Artemis A-Artemis deleted the aurelien/dataset-ie-keypoint-detection branch May 30, 2025 12:45
Comment on lines -81 to +92
point_cat.add(label_id=0, labels=[str(label.id_) for label in labels], joints=[])
if keypoint_structure:
label_id_to_idx = {label.id_: idx for idx, label in enumerate(labels)}
joints = []
for edge in keypoint_structure._edges:
node_1 = label_id_to_idx[edge.node_1]
node_2 = label_id_to_idx[edge.node_2]
joints.append([node_1, node_2])
positions = []
for position in keypoint_structure._positions:
positions.extend([position.x, position.y])
point_cat.add(label_id=0, labels=[str(label.id_) for label in labels], joints=joints, positions=positions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving point_cat.add(...) inside the if block is likely the cause of ITEP-68666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation IAI Interactive AI backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants