ITEP-33590 Dataset ie support for keypoint detection #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Artemis
changed the title
leoll2
previously approved these changes
May 12, 2025
interactive_ai/services/director/app/coordination/dataset_manager/dataset_counter_config.py
Show resolved
Hide resolved
…o aurelien/dataset-ie-keypoint-detection
github-actions
bot
added
the
documentation
…o aurelien/dataset-ie-keypoint-detection
…ection' into aurelien/dataset-ie-keypoint-detection
leoll2
approved these changes
May 30, 2025
leoll2
reviewed
Jun 2, 2025
Comment on lines
-81
to
+92
| point_cat.add(label_id=0, labels=[str(label.id_) for label in labels], joints=[]) | ||
| if keypoint_structure: | ||
| label_id_to_idx = {label.id_: idx for idx, label in enumerate(labels)} | ||
| joints = [] | ||
| for edge in keypoint_structure._edges: | ||
| node_1 = label_id_to_idx[edge.node_1] | ||
| node_2 = label_id_to_idx[edge.node_2] | ||
| joints.append([node_1, node_2]) | ||
| positions = [] | ||
| for position in keypoint_structure._positions: | ||
| positions.extend([position.x, position.y]) | ||
| point_cat.add(label_id=0, labels=[str(label.id_) for label in labels], joints=joints, positions=positions) |
There was a problem hiding this comment.
Moving point_cat.add(...) inside the if block is likely the cause of ITEP-68666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added Dataset import/export support for Keypoint detection.
The Datumaro parsers are updated to the handle the edges and positions of the Keypoints.
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: